[v26.1.x] rpc: derive requests_pending gauge from _correlations#30294
Closed
[v26.1.x] rpc: derive requests_pending gauge from _correlations#30294
Conversation
The manual counter was observed drifting over time. Replace it by reading `_correlations.size()` directly, which tracks the in-flight request count by construction and cannot drift. (cherry picked from commit 29cd963) Agent-Logs-Url: https://github.com/redpanda-data/redpanda/sessions/3905e3af-51cd-4562-9ecc-1bf9845e5275 Co-authored-by: nvartolomei <543193+nvartolomei@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [v26.1.x] Rpc: derive requests_pending gauge from _correlations
[v26.1.x] rpc: derive requests_pending gauge from _correlations
Apr 24, 2026
Member
|
@nvartolomei curious to know how this PR compares to the workflow changes i just added in PR #30290 to create similar backport PR #30295 if copilot triggered backports are easier by assigning to the github issue, i can revert my PR #30290 |
Contributor
|
I’ll check it out. Just playing around otherwise.
…On Fri, 24 Apr 2026 at 20:38, Andrew Hsu ***@***.***> wrote:
*andrewhsu* left a comment (redpanda-data/redpanda#30294)
<#30294 (comment)>
@nvartolomei <https://github.com/nvartolomei> curious to know how this PR
compares to the workflow changes i just added in PR #30290
<#30290> to create similar
backport PR #30295 <#30295>
if copilot triggered backports are easier by assigning to the github
issue, i can revert my PR #30290
<#30290>
—
Reply to this email directly, view it on GitHub
<#30294 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEETWMCKZ3CLBKWDQ6RWPL4XO7DVAVCNFSM6AAAAACYFOTLCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DGMJVG44DGOJXGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #30264
The
vectorized_rpc_client_requests_pendinggauge was observed drifting over time (occasionally reporting values nearUINT32_MAX). The manual_requests_pendingcounter had increment/decrement imbalances across error paths.Replace it with
_correlations.size(), which tracks in-flight requests by construction and cannot drift.Conflict resolution: v26.1.x uses
operator<<forclient_probeformatting vsformat_toon dev.Backports Required
Release Notes
Bug Fixes
vectorized_rpc_client_requests_pendinggauge drifting over time.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
dl.google.com/usr/lib/apt/methods/https /usr/lib/apt/methods/https(dns block)releases.bazel.build/home/REDACTED/bin/bazel bazel --version(dns block)/usr/local/lib/node_modules/@bazel/bazelisk/bazelisk-linux_amd64 /usr/local/lib/node_modules/@bazel/bazelisk/bazelisk-linux_amd64 build //src/v/rpc:rpc(dns block)If you need me to access, download, or install something from one of these locations, you can either: